std: Implement lowering and raising for process IO #25494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon |
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
force-pushed
the
stdio-from-raw
branch
from
0f35ebc to
af69f4e
Compare
This commit implements a number of standard traits for the standard library's
process I/O handles. The `FromRaw{Fd,Handle}` traits are now implemented for the
`Stdio` type and the `AsRaw{Fd,Handle}` traits are now implemented for the
`Child{Stdout,Stdin,Stderr}` types. Additionally this implements the
`AsRawHandle` trait for `Child` on Windows.
The stability markers for these implementations mention that they are stable for
1.1 as I will nominate this commit for cherry-picking to beta.
alexcrichton
force-pushed
the
stdio-from-raw
branch
4 times, most recently
from
b3db491 to
3dd3450
Compare
alexcrichton
added
beta-nominated
|
ping r? @aturon |
| /// Note that this function **does not** take ownership of the file | ||
| /// descriptor provided and it will **not** be closed when `Stdio` goes out | ||
| /// of scope. As a result this method is unsafe because due to the lack of | ||
| /// knowledge about the lifetime of the provided file descriptor, this could |
There was a problem hiding this comment.
I feel slightly uneasy about this comment, as it directly contradicts the documentation for the trait.
It would be good to be more crisp about the story here.
|
@bors: r+ |
|
📌 Commit 3dd3450 has been approved by |
|
(I'm assuming we still intend to backport; if not, feel free to r- and update stability markers.) |
bors
added a commit
that referenced
this pull request
May 29, 2015
This commit implements a number of standard traits for the standard library's
process I/O handles. The `FromRaw{Fd,Handle}` traits are now implemented for the
`Stdio` type and the `AsRaw{Fd,Handle}` traits are now implemented for the
`Child{Stdout,Stdin,Stderr}` types.
The stability markers for these implementations mention that they are stable for
1.1 as I will nominate this commit for cherry-picking to beta.
|
triage: not accepted for beta |
alexcrichton
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Jun 11, 2015
…=brson * Slate these features to be stable in 1.2 instead of 1.1 (not being backported) * Have the `FromRawFd` implementations follow the contract of the `FromRawFd` trait by taking ownership of the primitive specified. * Refactor the implementations slightly to remove the `unreachable!` blocks as well as separating the stdio representation of `std::process` from `std::sys::process`. cc #25494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements a number of standard traits for the standard library's
process I/O handles. The
FromRaw{Fd,Handle}traits are now implemented for theStdiotype and theAsRaw{Fd,Handle}traits are now implemented for theChild{Stdout,Stdin,Stderr}types.The stability markers for these implementations mention that they are stable for
1.1 as I will nominate this commit for cherry-picking to beta.